Fixed Client Props Disappearing

[MelonHeadzzz]

Bug: Client Props will disappear for no reason when selecting them using the context menu.
Description: While doing some testing, I've discovered that client props have a tendency to disappear when switched over using the Context Menu. Patterns I've noticed is:
- When they are slightly outside of map boundaries but most of it is still sticking out (shown in listed video)
- When they're in a corner (shown in the listed video)
- Sometimes for just no reason at all (sometimes it happens to posters according to some people I've asked?)
Errors/time:

[2023-09-13 13:19:02] Joaquin Saldanya has spawned 'models/jq/hlvr/props/xenpack/xen_tendril_01.mdl'.
[2023-09-13 13:19:10] Joaquin Saldanya has used a context menu option with the name: clientprop

Images/recording (optional):

 

[MelonHeadzzz]

Quick update, here's something I found of what seems to work and what seems to work less well. Props very close to the ground, like the small tendrils, do seem to disappear while others are fine. Again, my theory is that it's an issue with proximity to the map boundary.

 

[George]

It'll likely be due to the point from the prop being outside of the world, therefor it isn't able to be drawn

 

[M!NT]

This is intentional. You have to be within the potential visibility set of the prop for it to be rendered. When the prop is slightly in a wall or at some strange angle it may cause you to be in a different PVS, causing the props to vanish. This has to do with the map as well. I believe Astro has fixed a number of the broken visleafs in the map with the latest update.

I'm going to mark this as not-fixing because there is no fix that I know of. Automatic occlusion-based culling is one of the many modern features that the source engine sadly lacks. You can see this yourself in singleplayer by going around the map with wireframe enabled. So, we're forced to use visleafs. The only other option is to render them all at the same which would cause loads of crashes.